Skip to content

[!!!][TASK] Support PHP 8.5 and 8.6 and require TYPO3 13.4 - #9

Merged
Kanti merged 15 commits into
mainfrom
php85
Nov 19, 2026
Merged

Kanti merged 15 commits into
mainfrom
php85

Conversation

@N0S0I

@N0S0I N0S0I commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Allow and test PHP 8.5 with TYPO3 13.4. Align Composer requirements and the CI matrix, removing TYPO3 12. No application code changes.

Breaking change: TYPO3 12 is no longer supported on this development branch.

Validation: the GitHub Actions branch workflow passed for 5e0816402064e30f3c33915de3f829927af0dd68. This PR targets main.

Update: PHP 8.6

The branch already contains the current main (there are no new commits on main), so no merge was needed.

Added:

  • PHP 8.6 in the CI matrix and ~8.6.0 in the PHP constraint of composer.json.
  • The CI keeps --ignore-platform-req=php+ from main, because phpro/grumphp (a development dependency of pluswerk/grumphp-config) does not allow PHP 8.6 yet. The PHP 8.6 job therefore also runs composer check-platform-reqs --no-dev, so all runtime dependencies (TYPO3 13.4 and its dependencies) must allow PHP 8.6.

Removed:

  • The workflow uses the matrix style and the Composer steps of main again (php/typo3 lists, composer require typo3/minimal="^13" --dev --ignore-platform-req=php+ and composer install), as requested in the review. Only the PHP and TYPO3 versions differ from main.
  • ssch/typo3-rector is * again. The ^3.16.0 constraint was only needed for the prefer-lowest jobs, which were removed.

Kept: the removal of TYPO3 12, pluswerk/grumphp-config: ^11.2.0 (see the review question about removing versions 7 and 10) with the a9f/fractor-extension-installer plugin permission that version 11 needs, and the removal of cacheClass(FileCacheStorage::class) from rector.php (Rector 2.8 removed the class).

CI: green for PHP 8.2, 8.3, 8.4, 8.5 and 8.6 with TYPO3 13.

Blockers: none.

N0S0I commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Applicable feedback carried over from Kanti's reviews of other repositories:

  • Drop support for TYPO3 versions that are in ELTS, applying the same support policy to this extension (source review).
  • Reuse the existing GrumPHP checks instead of adding duplicate checks (source review).
  • Keep tests focused on this package; do not add tests of unrelated TYPO3 internals (source review).

@N0S0I
N0S0I requested a review from weakbit October 23, 2026 06:50
Comment thread .github/workflows/tasks.yml Outdated
include:
- php: '8.2'
typo3: '13'
dependencies: latest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies: latest

This isn't necessary; we didn't have it before, and we don't need it now either.

Comment thread Build/Scripts/check-compatibility.sh Outdated
@@ -0,0 +1,46 @@
#!/bin/sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not want a shell script for this, we do not need this here.
We did not have this before.

Comment thread grumphp.yml Outdated
parallel:
enabled: false
parameters:
convention.fractor_enable: false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we disable fractor?

Comment thread grumphp.yml Outdated
- { resource: vendor/pluswerk/grumphp-config/grumphp.yml }
grumphp:
parallel:
enabled: false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we disable parallel runs?

Comment thread rector.php Outdated
use Rector\Caching\ValueObject\Storage\FileCacheStorage;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->phpVersion(80200);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want a fixed version. We have the automated php version configuration.

Comment thread composer.json Outdated
},
"require-dev": {
"pluswerk/grumphp-config": "^7.2.0 || ^10.1.4",
"pluswerk/grumphp-config": "^7.2.0 || ^10.1.4 || ^11.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove version 7 or even version 10?

Comment thread .github/workflows/tasks.yml Resolved
Comment thread .github/workflows/tasks.yml Outdated
matrix:
php: [ '8.2', '8.3', '8.4' ]
typo3: [ '12', '13' ]
include:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the matrix style as it was before.

Keep the matrix and the Composer commands of the main branch and only
change the PHP and TYPO3 versions, as requested in the review.
…t jobs

The constraint was only needed for the prefer-lowest CI jobs, which were
removed again.
Test PHP 8.6 in CI and allow it in composer.json. phpro/grumphp (a
development dependency) does not allow PHP 8.6 yet, so the PHP 8.6 job
checks that all runtime dependencies allow PHP 8.6.
@Kanti Kanti changed the title [!!!][TASK] Support PHP 8.5 and require TYPO3 13.4 [!!!][TASK] Support PHP 8.5 and 8.6 and require TYPO3 13.4 Nov 19, 2026
@Kanti
Kanti merged commit 9738da4 into main Nov 19, 2026
10 checks passed
@Kanti
Kanti deleted the php85 branch November 19, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants