Repository navigation
feat(@schematics/angular): use library builder and add entry-point schematic - #34645
alan-agius4 wants to merge 6 commits into
Conversation
angular-robot
Bot
added
detected: feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new "entry-point" schematic to generate secondary entry points for Angular libraries, and transitions the library schematic to use the "@angular/build:library" builder instead of "ng-packagr" configuration files. Feedback is provided to deduplicate path mappings in "tsconfig.json" when updating the configuration to prevent duplicate entries upon multiple runs.
alan-agius4
added
the
target: minor
…hematic Update the library schematic to configure @angular/build:library with a single tsconfig.lib.json instead of @angular/build:ng-packagr, and add an entry-point schematic to generate secondary entry points under src/<name>/.
f95c4e5 to
c033dbc
Compare
alan-agius4
added
the
action: review
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'entry-point' schematic to generate secondary entry points for Angular libraries, and refactors the existing 'library' schematic to use this new schematic for generating the primary entry point. It also replaces the 'ng-packagr' builder with the new '@angular/build:library' builder, removing obsolete configuration files like 'ng-package.json' and 'tsconfig.lib.prod.json'. Feedback on the changes suggests making the path resolution for 'tsConfigPathTarget' in the 'entry-point' schematic more robust by checking for existing relative or absolute path prefixes before prepending './'.
60ae3e1 to
b4486a5
Compare
1a5df35 to
98c90c5
Compare
Updates the
libraryschematic to configure@angular/build:librarywith a singletsconfig.lib.jsonand introduces anentry-pointschematic to generate library entry points undersrc/<name>/.Closes #19070