Repository navigation
techdebt: parameterise map typed API parameters - #14580
DaanHoogland wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14580 +/- ##
===========================================
Coverage 20.72% 20.73%
- Complexity 20774 20794 +20
===========================================
Files 6049 6049
Lines 547761 547747 -14
Branches 78397 73175 -5222
===========================================
+ Hits 113539 113576 +37
+ Misses 420906 420857 -49
+ Partials 13316 13314 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19922 |
ee65ee9 to
764d597
Compare
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.64% |
| Branch coverage | 20.80% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19925 |
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu24 mgmt + kvm-ubuntu24, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17504)
|
|
[SF] Trillian test result (tid-17501)
|
|
[SF] Trillian test result (tid-17502)
|
|
[SF] Trillian test result (tid-17503)
|
|
[SF] Trillian test result (tid-17508)
|
|
[SF] Trillian test result (tid-17509)
|
|
[SF] Trillian test result (tid-17507)
|
|
@blueorangutan test ubuntu24 kvm-ubuntu24 |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + kvm-ubuntu24) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17531)
|
764d597 to
ed2f971
Compare
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Description
Addresses the parameterised-types part of #3360.
Raw
Mapfields on API commands are replaced withMap<Integer, Map<String, String>>. This matches whatParamUnpackWorker actually builds for
param[i].key=valueinput, forsync and async commands alike. Getters and setters are typed to match:
Map<String, String>store migration) take the indexed map
Response classes get typed
detailsmaps. NetworkOffering, BgpPeerand VolumeForImport use their enum
Detailkeys; Gson serialisesthose by name, so the output is the same.
No API behaviour changes: listApis still reports these parameters and
response fields as
map. That leaves the apidocs, CloudMonkey andMarvin's generated client unchanged.
Fixes: #3360
Types of changes
How Has This Been Tested?
veeam-control-service, metrics and the external hypervisor plugin.
and server (459, including UserVmManagerImplTest,
AutoScaleManagerImplTest, VnfTemplateManagerImplTest and
ConfigurationManagerTest).
🤖 Generated with Claude Code