Repository navigation
server: encrypt a volume created on a storage pool with an encrypted disk offering - #14667
weizhouapache wants to merge 1 commit into
Conversation
…disk offering A volume created with a storageid is created on the pool right away, without the passphrase or the KMS key which an encrypted disk offering needs, so it was created without encryption. Set up its encryption before it is created.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14667 +/- ##
============================================
- Coverage 18.32% 18.31% -0.01%
+ Complexity 16644 16642 -2
============================================
Files 5939 5939
Lines 537787 537794 +7
Branches 65932 65932
============================================
- Hits 98544 98511 -33
- Misses 428033 428079 +46
+ Partials 11210 11204 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19996 |
| return; | ||
| } | ||
| VolumeVO volume = _volsDao.findById(volumeId); | ||
| setPassphraseForVolumeEncryption(volume); |
There was a problem hiding this comment.
for main/24, this line should be
setPassphraseForVolumeEncryption(volume, getKmsKeyFromVolume(volume), volume.getAccountId());
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
A volume created with a storageid is created on the pool right away, without the passphrase or the KMS key which an encrypted disk offering needs, so it was created without encryption. Set up its encryption before it is created.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Environment: Trillian test env
pr147-n88(Ubuntu 26.04, KVM, two management servers, two KVM hosts, Ceph RBD primary poolsceph-pri1andceph-pri2, plus an NFS primary pool). The management servers ran a 4.23 build with the same change, not this 4.22 branch. The KVM agents were not changed.Steps: create an encrypted disk offering (
encrypt=true), then create a volume from it with an explicitstorageidon each pool. The volumes were not attached to a VM.passphrase_idin DBencrypt_formatin DBqemu-img inforeportsencrypted: yesNot covered by these tests:
How did you try to break this feature and the system with this change?
Not yet tested beyond the cases above.