[nvazquez]

Description

This PR restricts the filesystem check for the VDDK library only when the property vddk.lib.dir is set on agent.properties

Fixes: #13497

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.32%. Comparing base (b56bbc2) to head (4417aab).

Files with missing lines	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #14688      +/-   ##
============================================
- Coverage     18.32%   18.32%   -0.01%     
+ Complexity    16644    16643       -1     
============================================
  Files          5939     5939              
  Lines        537787   537785       -2     
  Branches      65932    65931       -1     
============================================
- Hits          98544    98542       -2     
+ Misses       428033   428032       -1     
- Partials      11210    11211       +1     

Flag	Coverage Δ
uitests	4.08% <ø> (ø)
unittests	19.41% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✖️ suse15. SL-JID 20021

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[timmyzhu]

I'm not an official reviewer, but I do not believe this fixes the issue. It does not address the root cause, and I don't think it'll even workaround the issue. The root cause is the vddk detection is far too slow. Doing a search of the entire filesystem is not a good design and should be avoided. My recommendation would be to remove the detection, but I'm not a cloudstack developer or maintainer.

If there's no way to remove the detection or change the detection to not scan the entire root filesystem, then this change only addresses one of the calls to detectVddkLibDir. As noted in the bug report, there's another case where detectVddkLibDir is called in the hostSupportsVddk function, and I believe this will likely cause the bug to persist. Generally, calling a host supports function is not expected to take dozens of minutes, which would occur when the detectVddkLibDir function is called within the function. Within the hostSupportsVddk function, moving the hostSupportsInstanceConversion() function call from the return to the beginning of this function could potentially workaround this issue. At minimum, this should be included in this PR and tested that it's working as expected, but it doesn't address the design issue with the detection.

[nvazquez]

Thanks @timmyzhu I have missed the check on hostSupportsVddk(), I have now removed it. Please have another review when possible

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.