Repository navigation
HIVE-29591: Create Hive precommit image and move Dockerfile into the hive repository - #6953
Merged
abstractdog merged 8 commits intoNov 16, 2026
Merged
Conversation
abstractdog
force-pushed
the
HIVE-29591-precommit-image
branch
from
November 9, 2026 13:59
46def98 to
101acd8
Compare
abstractdog
force-pushed
the
HIVE-29591-precommit-image
branch
from
November 10, 2026 10:02
101acd8 to
84fa9dc
Compare
abstractdog
force-pushed
the
HIVE-29591-precommit-image
branch
from
November 11, 2026 11:11
84fa9dc to
698ecdd
Compare
zabetak
approved these changes
Nov 12, 2026
Comment on lines
+64
to
+67
| if docker manifest inspect "$image" > /dev/null 2>&1; then | ||
| echo "::error::$image is already published, and a published tag is never overwritten. Bump org.opencontainers.image.version in the Dockerfile (or pick another tag for a manual run)." | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
We can disable tag overwrite directly in DockerHub if we want to.
- Move the image to dev-support/docker/ci/runner. - Drop the init@<db> stages and precommit-init-metastore.sh (DbInstallBase already covers schematool), and with them Hadoop from the image. - Drop smoke-test.sh. - Version the image with its org.opencontainers.image.version label: publish apache/hive-ci-runner:<version>, never overwrite a published tag, and pin the tag in the Jenkinsfile. - Trim the README to the steps people actually follow. Co-Authored-By: Claude Code <[email protected]>
docker 20.10 cannot extract the current mcr.microsoft.com/mssql/server:2019-latest
layers ("archive/tar: invalid tar header", microsoft/mssql-docker#978), which fails
TestSchemaToolForMetastore[mssql].
A push to a fork's master only syncs apache/hive, and the tag check fails there once apache/hive has published the version. Forks still build the image on their PRs and manual runs. Co-Authored-By: Claude Code <[email protected]>
… does not need a new version When the tag is published already, the workflow fails only if the Dockerfile changed (against the target branch of a PR, or the previous head of a push); otherwise it builds the image but skips publishing it. A manual run with an existing tag still fails.
abstractdog
force-pushed
the
HIVE-29591-precommit-image
branch
from
November 13, 2026 06:22
22e9acc to
410a568
Compare
zabetak
approved these changes
Nov 13, 2026
…t, which the Jenkinsfile uses A change of the Dockerfile no longer needs a version bump, nor a follow-up pull request that bumps the Jenkinsfile: on master the workflow publishes apache/hive-ci-runner:<UTC timestamp>-<commit> and moves apache/hive-ci-runner:latest to it. A manual run on another branch publishes a candidate without moving latest. Only the newest 5 <UTC timestamp>-<commit> tags are kept. Co-Authored-By: Claude Code <[email protected]>
|
Contributor
Author
|
merged, waiting for action to build and push initial |
Contributor
Author
yay, initial image is there: https://hub.docker.com/layers/apache/hive-ci-runner/latest/images/sha256-eb599f384ccaf4201a0585999a9b3e68f5cbb9f63b07933364d637d649f7e7c7 |
kuczoram
pushed a commit
to kuczoram/hive
that referenced
this pull request
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
A precommit image in
dev-support/docker/ci/runner. It is based on Debian trixie-slim and contains:A GitHub Actions workflow,
precommit-image.yml. On PRs that change the Dockerfile, it builds the image. On master it publishes the image for amd64 and arm64 asapache/hive-ci-runner:<version>, where<version>is theorg.opencontainers.image.versionlabel of the Dockerfile. A published the workflow fails if the tag already exists. A manual run can publish a candidate under atag of its own.The Jenkinsfile runs in
apache/hive-ci-runner:1instead of `ayushtkn/hive-dev-box:esw java,/etc/profile.d/*.sh, `git config extrMAVEN_ARGS(Maven 3.9+), in place of the dev-boxmvnwrapper.IMAGEbuild parameter lets a run use a candidate image.The
init@derbyandinit@postgresstages are removed.DbInstallBasealready coversschematoolon more databases, andInformationSchemaWithPrivilegeTestBasecovers the SYS/INFORMATION_SCHEMAinitialization. This also keeps Hadoop out of the image.
cachingprintstream.qandstack_trace.qnormalize the exec failure message withqt:replace:error=2, No such file or directory.This line is the only difference in the output, so the tests still check the same failure.
A README on how to change, try and roll out the image.
The docker and helm action pins in
docker-images.ymlandhive-postgres-tpcds-metastore.ymlare bumped to the versionsprecommit-image.ymluses. Some of the old pins were close to their expiry datesin the ASF allowlist.
Why are the changes needed?
The precommit image used to be built from a separate repository (hive-dev-box) and pushed to a personal Docker Hub account. Keeping the Dockerfile in the Hive repository and publishing it from CI makes the
image reviewable and reproducible, and removes the dependency on a personal account. See HI
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally, in the image with a
docker:dindsidecar:mvn install -DskipTests -Pitests,distsucceeds.newline.q(pythonTRANSFORM) onTestMiniLlapCliDriverjdbc_project_pushdown.q(postgres in docker) onTestMiniLlapLocalCliDriverstack_trace.qonTestNegativeLlapCliDrivercachingprintstream.qonTestNegativeLlapLocalCliDriverA full precommit run with the candidate image (
IMAGE=abstractdog/hive-precommit:HIVE-29591-v3):https://ci.hive.apache.org/job/hive-precommit/job/PR-6953/12/