Repository navigation
Conversation
- A footer miss read the footer length from the last 8 bytes, then the footer: two reads, plus the HEAD S3A's open() issues to learn the length - getFooterBuffersFromCache reads the last 64 KB (S3A's default readahead) once and caches the footer from it; a footer larger than that is read on its own - The file is opened with the status already fetched, so S3A skips the HEAD - The length, magic and footer index are checked as ParquetFileReader.readFooter checks them, before caching - ParquetEncodedDataReader builds the footer read options once: readFooter(InputFile, filter) built them per split, parsing the Hadoop default configuration each time (18.5% of q28's LLAP task time at 10 TB, 51,134 splits); a footer read of a local file 631 -> 43 us - TestParquetEncodedDataReader: one read for a footer within the tail, two for a larger one; a short file, a missing magic and a footer index outside the file are refused and not cached
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
LlapParquetIoImpl.getFooterBuffersFromCachereads the last 64 KB of the file once (S3A'sdefault readahead) and caches the footer from that buffer. A footer larger than that is read on its own.
openFile().withFileStatus()), so S3A skips the HEAD thatopen()issues to learn the length.ParquetFileReader.readFooterchecks them, before anything iscached.
ParquetEncodedDataReaderbuilds the footerParquetReadOptionsonce instead of once per split.Why are the changes needed?
open(): three object-store requests where one is enough.ParquetFileReader.readFooter(InputFile, filter)builds read options for a non-Hadoop file on every call, whichparses the Hadoop default configuration. At TPC-DS 10 TB that was 18.5% of q28's LLAP task time (51,134 splits).
A footer read of a local file goes from 631 to 43 us.
Does this PR introduce any user-facing change?
No
How was this patch tested?
TestParquetEncodedDataReader:ParquetFileReader's footer