Repository navigation
Conversation
MrJs133
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Empty or zero-effective-weight Louvain inputs can enter invalid normalization paths. Define identity communities and zero algorithm modularity for this case, reject invalid finite/range parameters and weighted edges, and skip zero-weight adjacency while preserving the positive-weight optimization path.
Dependency and validation boundary
This source branch is stacked on 🔗 org Computer #25. Its ASF comparison targets master because the parent branch does not exist there, so it includes the readiness foundation from 🔗 Computer #372. Merge the parent first, then recheck the remaining diff; this is not an independent change.
The author reports Go 1.23.7 algorithms/worker race tests. Current review still notes missing coverage of the zero-weight early-return and invalid-edge initialization paths. Generic modularity statistics and multi-worker acceptance remain separate; tests were not independently rerun for this submission.
Source: 🔗 org Computer #26.
Visual overview
Degenerate-input design: validate parameters and weights, remove zero-weight adjacency, then publish identity communities when effective weight is zero. Includes the readiness foundation from the parent PR. This is not independent multi-worker validation or proof that every zero-edge statistics path is finite.