Repository navigation
fix(vermeer): correct distributed closeness traversal - #374
Merged
imbajin merged 6 commits intoNov 5, 2026
Merged
Conversation
MrJs133
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Use global source IDs, sample adjacency once per run, finish each local source from its own frontier, and aggregate stop slots after the compute barrier. Compute normalized closeness with 64-bit distance sums and add local output-completeness checks.
Validation boundary
The author reports Go 1.23.7 algorithms/worker race tests. Current review identifies unresolved max-step completion, per-worker versus global output gating, and traversal-test coverage issues: 🔗 org Computer #27 review. These changes do not establish atomic all-worker output or merge readiness. All-source state still scales with local sources times reachable vertices; performance batching is separate. No independent tests or cluster run were performed for this submission.
Source: 🔗 org Computer #27.
Visual overview
Traversal design illustration: global IDs, fixed sampled adjacency, per-source completion and wider score accumulation. Current review still flags max-step and global output-gating issues; the diagram is not proof that partial distributed output is prevented, or that memory, cluster or RC acceptance has passed.