Repository navigation
[Pipe] Guard DAL lifecycle and drain producers before region cleanup #19321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jt2594838
merged 2 commits into
apache:master
from
Pengzna:codex/fix-dal-region-cleanup-warn
Nov 20, 2026
+824
−82
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getInstance() builds the manager inside ConcurrentHashMap.computeIfAbsent(), and the entry is not visible until initAndRecover() returns. If region deletion reaches this helper while that initialization is in flight, get() returns null here and this branch deletes the directory the constructor is recovering; it can then finish with a live buffer pointing at a deleted DAL. Please serialize cleanup with per-region manager creation (and cover this overlap in a regression test) before deleting the directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in dd1a121.
getInstance()andcloseAndRemoveDAL()now share a stable region lifecycle lock, including the constructor/recovery and the complete close/remove sequence. Cleanup also leaves a deleted-region tombstone, cleared only by storage region creation, so late tasks cannot recreate DAL after cleanup. Added latch-controlled regressions that pause initialization before the map entry is published and pause cleanup after manager close but before directory removal; competing cleanup/creation must wait, and creation is rejected after deletion.