[janbuchar]

• closes Add support for the request_id param in Actor.charge() #1193

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.82%. Comparing base (b7a6165) to head (e0af5d3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/apify/_charging.py	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   93.79%   93.82%   +0.02%     
==========================================
  Files          54       54              
  Lines        3803     3821      +18     
==========================================
+ Hits         3567     3585      +18     
  Misses        236      236              

Flag	Coverage Δ
e2e	31.32% <18.18%> (-0.13%)	⬇️
integration	51.19% <27.27%> (-0.17%)	⬇️
unit	91.02% <90.90%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Pijukatel]

It feels like an attachment to conceptually same method, that should have separate implementation though.

Actor.charge in normal actor runs is responsible for

• book keeping of the events + newly persistence
• limit enforcement
• API call

in multi tenant sever actor there is no enforcement and the bookkeeping is pointless so it is there only for the API call. So this similar but different method goes through the same code paths, but has so much dead code along the way.

In order to make this distinction more clear I would be in favor of some separation. For example something in this direction:

Having overloads for normal charge

    async def charge(
        self,
        event_name: str,
        *,
        count: int = 1,
        idempotency_key: str | None = None,

Server charge where the request_id is actually mandatory

    async def charge(
        self,
        event_name: str,
        *,
        count: int = 1,
        idempotency_key: str | None = None,
        request_id: str,

And the method should clearly delegate to distinct internal functions

async def charge(...)
  # param checks and warnings
  if ...
    return _server_charge(...)
  return _charge(...)

[vdusek]

One more comment regarding docs. Otherwise LGTM.

[vdusek]

Could we mention somewhere here that "server Actor" is the new name for "standby Actor"? Something like what we have in https://docs.apify.com/api/client/python/docs/concepts/server-actors.