Repository navigation
fix: preserve JSON scalar input types in local storage - #1243
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
t-tooling
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pre-existing
INPUT.jsonor valid JSONINPUTfile in local storage gets its metadata inferred from the parsed value. Scalars then read back as plain text or bytes, sofalse,42, andnulllose their JSON types.This keeps successful JSON parsing as the source of the content type. The tests cover both filenames, scalar and falsy values, object/array controls, unchanged input bytes, explicit metadata, and malformed JSON. Existing metadata is respected; this does not rewrite sidecars created earlier.
Tested:
uv run poe check-code(lint, type check, 767 unit tests) and the focused filesystem/Actor/storage tests (75 passed).Prepared with Codex assistance.