Skip to content

feat(request-loaders)!: Make inner optional in ThrottlingRequestManager - #2388

Open
Mantisus wants to merge 1 commit into
apify:v2from
Mantisus:throttler-optional-inner
Open

Mantisus wants to merge 1 commit into
apify:v2from
Mantisus:throttler-optional-inner

Conversation

@Mantisus

@Mantisus Mantisus commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Description

ThrottlingRequestManager no longer needs a request manager to wrap. Without inner, it opens the default store through request_manager_opener on first use, the same as in Crawlee JS, so ThrottlingRequestManager(domains=[...], request_manager_opener=RequestQueue.open) is enough. Until then the inner property is None. For details, see the upgrading guide.

Issues

✍️ Drafted by Claude Code

@Mantisus Mantisus self-assigned this Nov 2, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 2, 2026
@Mantisus
Mantisus force-pushed the throttler-optional-inner branch from 8186e26 to 5fd47df Compare November 5, 2026 20:21
@Mantisus
Mantisus force-pushed the throttler-optional-inner branch from 5fd47df to ea105da Compare November 7, 2026 20:07
@Mantisus
Mantisus marked this pull request as ready for review November 9, 2026 23:25
@Mantisus
Mantisus requested a review from vdusek November 9, 2026 23:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant