Repository navigation
Conversation
github-actions
Bot
added
the
t-tooling
vdusek
reviewed
Nov 6, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Maybe again could we split this into 2 PRs ? 🙂
- feat(request-loaders): Add
persist_state()toSitemapRequestLoader - feat(request-loaders)!: Raise in
SitemapRequestLoader.mark_request_as_handledfor a request it isn't processing
Mantisus
changed the title
persist_state() to SitemapRequestLoader and raise for a request it isn't processingSitemapRequestLoader.mark_request_as_handled for a request it isn't processing
Mantisus
force-pushed
the
sitemap-loader-persist-state
branch
from
November 9, 2026 23:18
c5b65e9 to
8aee396
Compare
Collaborator
Author
Splited, another PR: #2430 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SitemapRequestLoader.mark_request_as_handlednow raises aValueErrorfor a request the loader isn't processing, as in Crawlee JS. For details, see the upgrade guide.fetch_next_requestdoesn't return a URL again while its request is still in progress, for example when several sitemaps list it.Issues
SitemapRequestLoader#2420✍️ Drafted by Claude Code