Repository navigation
fix: paginate filesystem key-value stores by logical key - #2431
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filesystem key-value stores sort physical filenames but return logical metadata keys. With
itemanditem-1, one-record pages omititem; a filename alias such as the SDK'sINPUT.jsoncan returnINPUTagain after that cursor.This uses validated metadata keys for sorting and cursor filtering before applying the limit. It adds native pagination, metadata-alias, and invalid-metadata coverage. Filenames, stored values, public signatures, and log messages stay unchanged.
Listing now reads metadata for every record before yielding a page. It keeps metadata in memory for sorting, without reading record values.
AI assistance: I used Codex to investigate, implement, and test this change.
Issues
No linked issue.
Testing
uv run poe lint: passed.uv run ty checkfor the changed source and test files: passed.INPUTandINPUT.jsonboth end after cursorINPUT.uv run poe check-codewas attempted. Full type checking is blocked by missing optional dependencies and a type error in the unchanged BeautifulSoup parser. Full unit and integration attempts stop during collection on optional dependency imports. Hosted CI has not run.Checklist