Repository navigation
Conversation
BREAKING CHANGE: remove Appium.symbolize_keys and automatic implicit waits configured through appium_lib[:wait]. Use explicit waits and migrate downstream callers before upgrading to core 14.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated client APIs and legacy JSONWP/MJSONWP element handling for core 14 and Appium 4. Supersedes #674 while preserving @aguspe's original commits, with current master merged in.
Appium.symbolize_keys,appium_lib[:wait],default_wait, andset_implicit_wait_by_default. Session creation no longer sets implicit timeouts; explicit Selenium timeout configuration remains supported.Element#location_rel; documentelement.rectand explicit relative-center calculation.take_element_screenshotcompatibility alias; usesave_element_screenshot.Bridge#actionto keyword arguments (async:,devices:).ELEMENTas data. Preserve noncompact W3C cached attributes and shadow-root handling.NoSuchElementErrorby default. Other exceptions propagate unless explicitly configured withignored:; connection refusal still propagates immediately. Document the migration and cover exception identity, retry behavior, aliases, timeout messages, and success conditions.driver.wait_trueconditions; restore the keyboard IME and close the notification shade in cleanup.Capabilities#convert_key, with regression coverage for nested Chrome preference keys containing underscores.get_timeouts.CI coverage
ruby-headjob for early compatibility feedback.Major release and downstream coordination
Use this PR's
feat!:title when squash-merging so Release Please prepares 14.0.0. Version, date, manifest, and generated release entries belong in the release PR. The detailed migration guide is recorded in CHANGELOG.md with an unreleased notice, separate from versioned release headings.ruby_libcurrently requires core< 14.0. Before relaxing that constraint, a separate compatibility change must adaptAppium.symbolize_keys,core.default_wait, wait helpers, and the removed screenshot alias. This also affects console/Capybara users throughruby_lib.Validation
BREAKING CHANGE: Remove deprecated key normalization, automatic implicit-wait configuration, location_rel, the take_element_screenshot alias, the bridge action positional argument, and legacy ELEMENT reference handling. Wait helpers now retry only NoSuchElementError by default. See the CHANGELOG migration guide for replacements; the README links to it with a short summary.