Repository navigation
Conversation
commit: |
cowboyd
force-pushed
the
wpt-suite-fixes
branch
from
November 10, 2026 02:01
010345e to
49338ac
Compare
cowboyd
changed the title
While implementing DOM features I noticed the coding agent engaging in the following pathological behaviors: 1. changing the WPT tests in order to accomodate a feature I was adding to the DOM, and allowing it to drift from upstream. 2. Writing its own test cases outside the WPT suite for behavior that was explicitly covered by the WPT 3. Not being sure what exactly each WPT test was supposed to cover. This adds stricter guardrails around what is allowed in the WPT and instructs future agents to respect them. It stipulates that every test file must reference, via a comment, the upstream source from which it derives (The specific revision of the WPT is in the /WPT_REVISION file). This allows agents to quickly navigate to the source of the test. Furthermore, it strengthens the language to say that the upstream WPT should be followed very closely when adding new tests, or implementing functionality. Then, I had it re-sync with the upstream WPT and ended up with a test suite that is much more faithful to the original implementation. In fact, it got me thinking that once we have HTML parsing as part of our functionality, we can switch to use the upstream tests directly.
cowboyd
force-pushed
the
wpt-suite-fixes
branch
from
November 10, 2026 02:09
49338ac to
8de8b8d
Compare
cowboyd
marked this pull request as ready for review
November 10, 2026 02:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force align test sources with upstream WPT
While implementing DOM features I noticed the coding agent engaging in the following pathological behaviors:
This adds stricter guardrails around what is allowed in the WPT and instructs future agents to respect them. It stipulates that every test file must reference, via a comment, the upstream source from which it derives (The specific revision of the WPT is in the /WPT_REVISION file). This allows agents to quickly navigate to the source of the test.
Furthermore, it strengthens the language to say that the upstream WPT should be followed very closely when adding new tests, or implementing functionality.
Then, I had it re-sync with the upstream WPT and ended up with a test suite that is much more faithful to the original implementation. In fact, it got me thinking that once we have HTML parsing as part of our functionality, we can switch to use the upstream tests directly via vendoring or via a git submodule.