[gnodet]

Fixes #633

Summary

Adds three new field-level XSD metadata attributes to modello-plugin-xsd:

Attribute	Mode	Generated XSD
xsd.enumerations	Strict — rejects unknown values	xs:restriction with xs:enumeration
xsd.suggestions	Non-strict — IDE completion only	xs:union of enumeration + xs:string
xsd.pattern	Regex validation	xs:restriction with xs:pattern

Usage

<!-- Strict: only compile/runtime/provided/test/system are schema-valid -->
<field xsd.enumerations="compile,runtime,provided,test,system">
  <name>scope</name>
  <type>String</type>
</field>

<!-- Suggested: IDE completion for known values, custom values still accepted -->
<field xsd.suggestions="jar,pom,war,ear,maven-plugin">
  <name>packaging</name>
  <type>String</type>
</field>

<!-- Pattern: validates coordinate format -->
<field xsd.pattern="[a-zA-Z0-9._\-]+">
  <name>artifactId</name>
  <type>String</type>
</field>

Generated XSD (strict enumeration example)

<xs:element minOccurs="0" name="scope">
  <xs:simpleType>
    <xs:restriction base="xs:string">
      <xs:enumeration value="compile"/>
      <xs:enumeration value="runtime"/>
      <xs:enumeration value="provided"/>
      <xs:enumeration value="test"/>
      <xs:enumeration value="system"/>
    </xs:restriction>
  </xs:simpleType>
</xs:element>

Changes

• XsdFieldMetadata: add enumerations, suggestions, pattern fields
• XsdMetadataPlugin: parse xsd.enumerations, xsd.suggestions, xsd.pattern from the field data map
• XsdGenerator: emit inline xs:simpleType when any constraint is present; plain type="xs:string" used only for unconstrained fields; also supports constrained xs:attribute fields
• EnumerationXsdGeneratorTest + fixtures: cover all three modes, verify structural XSD content via XPath, validate that good XML passes and bad values/patterns are rejected, and confirm that custom values outside xsd.suggestions still pass validation

[gnodet-bot]

The PR adds xsd.enumerations, xsd.suggestions, and xsd.pattern field metadata to the Modello XSD generator — a genuinely useful feature with thorough Javadoc and XSD validation tests. A few things to address before this is ready:

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Following up on my earlier review — all 4 findings have been addressed:

• ✅ getEnumerations() / getSuggestions() — now return Collections.unmodifiableList(...), preventing external mutation.
• ✅ Mutual-exclusivity validation — getFieldMetadata() now throws ModelloException when more than one of xsd.enumerations, xsd.suggestions, or xsd.pattern is set on the same field.
• ✅ xml.attribute="true" test coverage — attributeScope field added to the .mdo fixture with enumeration constraint; assertion 5 in testEnumerationConstraints verifies the attribute-field code path.

LGTM.

This review was generated by an AI agent, Hermès on behalf of @gnodet.