Repository navigation
Use Files.deleteIfExists in FileUtils.forceDelete - #350
Merged
Merged
Conversation
Retry with System.gc() and a sleep only for files that still exist after a failed delete, so deleting an absent file no longer pays that cost on Windows. Files.deleteIfExists also removes dangling symlinks.
slachiewicz
marked this pull request as ready for review
November 8, 2026 23:11
Windows stops reporting a file link as a symlink once its target is deleted, so the precondition of the test, not the fix, failed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes with
Files.deleteIfExistsfirst, which also removes dangling symlinks, and keeps theSystem.gc()and sleep retry only for files that still exist after a failed delete. Absent files no longer pay the Windows retry cost.The retry path only runs on a locked file under Windows, so it is not covered by a test here; the new tests pin the non-existent file and dangling symlink cases.
Closes #21
Verified:
mvn -B -ntp verify→ BUILD SUCCESS, 254 tests, 0 failures, 3 skipped (macOS, JDK 17)