Repository navigation
Poll System.in for stdin in CommandLineUtils.executeCommandLine - #351
Merged
Merged
Conversation
A process that exits without reading stdin no longer leaves the caller waiting in a blocking read of System.in. Other input streams keep using StreamFeeder, because available() == 0 does not mean end of input for them and the process would never see EOF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
StreamPollFeederfrom Maven Shared Utils (apache/maven-shared-utils#140, MSHARED-1072), which pollsavailable()with a short sleep instead of blocking inread(), and uses it whensystemInisSystem.in. Other streams keepStreamFeeder:available() == 0does not mean end of input for them, so polling would never close the process stdin.Closes #260
Verified:
mvn -B -ntp verify→ BUILD SUCCESS, 257 tests, 0 failures, 3 skipped; theSystem.intest times out on master (macOS, JDK 17)