Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
EsadCetiner
left a comment
There was a problem hiding this comment.
Isn't there a blue dark theme?
This theme is dark blue with a green sidebar. |
|
@Xhoenix It doesn't match the light theme at all, it's inconsistent. Can you add some custom styling so both light/dark look the same? |
Can you check now? The 'auto' relies on the same theme as 'relearn-light' and 'relearn-dark' so it's consistent. Should we provide more colour options to users in the theme picker dropdown menu of sidebar? |
|
@Xhoenix Both the light and dark themes are consistent, but there's still plenty of green. The docs page needs to match CRS's branding, it looks unprofessional and amateurish to go from mostly blue in the main site to mostly green in the docs subsite. Hugo supports adding custom CSS, so you may need to do that to keep the branding consistent. |
|
Haven't checked the entirety of docs, so probably missed those greens you're mentioning. Going to see if something can be done. |
|
Is that really necessary? If yes, which parts need to be modified, and who decides that? Isn't the whole point about switching to a dark theme? I think the defaults are well thought out by the author. Should I modify everything to the blue color? |
|
@Xhoenix It's going to look jarring when someone is on our main website and sees mostly blue then opens our docs and sees green everywhere. That's fine for a hobby site but I don't think it's fine for an organization like CRS. @coreruleset/crs-leaders Are you ok with the docs theme having a green theme when our main site is mainly blue? Isn't CRS's branding specifically the color blue and not green? |
|
@EsadCetiner The simplest way I see is changing everything to blue. We are currently using the "blue" theme and I just need to copy the entries. |
What
Add Dark Mode support for relearn theme based on user's OS settings
Why
Because Dark Mode
Reference: Adjust to OS Settings
Note: Added another themeVariant in comments that lets the user choose between color modes.