Repository navigation
docs(ocm): enforce notification payload schemas - #434
MahdiBaghbani wants to merge 7 commits into
Conversation
|
I deleted the from the OpenAPI file based on the idea that the IP and MLS should have their own |
|
Great! I had in mind exactly something like this yesterday when commenting on Micke's PR for the collections! |
|
I hope that we don't get into lots of conflicts when merging 😄 |
On that though I'm not sure I agree: OCM-IP likely does not need any spec.yaml, given that it's all about the semantic of the token, and OCM-MLS is based on standard notifications. Until really necessary, I think it's best if we keep all of them in the same |
|
I concur, I actually created the #435 in hopes to come back to it later if I have time, both the IP and MLS can be managed inside the |
07a895b to
1df3dc5
Compare
1df3dc5 to
499aab9
Compare
499aab9 to
8b786a1
Compare
8b786a1 to
cafba35
Compare
cafba35 to
26e776e
Compare
glpatcern
left a comment
There was a problem hiding this comment.
A few changes, but I'd love this be merged soon!
| resourceType: file | ||
| senderDomain: sender.example.org | ||
| notification: | ||
| message: Something happened |
There was a problem hiding this comment.
| message: Something happened | |
| message: Something happened | |
| file: | |
| customKey: customValue |
There was a problem hiding this comment.
Applied your suggested example
| - GROUP_REMOVED | ||
| - OCM_SERVER_ADDED | ||
| - OCM_SERVER_REMOVED | ||
| NotificationPermission: |
There was a problem hiding this comment.
What about factoring this out between here and the NewShare payload?
There was a problem hiding this comment.
Factored the values into SharePermission and reused it in notifications and NewShare, with view restricted to webapp
Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
Co-authored-by: Giuseppe Lo Presti <[email protected]> Signed-off-by: Mahdi Baghbani <[email protected]>
26e776e to
6d9f9f8
Compare
6d9f9f8 to
a03fc64
Compare
This PR is part of cs3org/OCM-STA#57.
Summary
Enforce the payload requirements for built-in notifications while accepting valid unknown types. Correct the examples and add focused payload checks to CI.