Repository navigation
Conversation
linkedLauncher creates its links under os.tmpdir(), which on macOS is a symlink (/tmp -> /private/tmp, /var -> /private/var). path.relative() computes the link target lexically from the symlinked path, but the kernel resolves the link's ".." segments from the physical directory, which is one level deeper, so the spawn target does not exist and the "launcher reached through a symlink" test fails. Resolve the temp directory with fs.realpathSync() before building the link so both sides are physical. Fixes cursor#1164.
The Windows JVM writes CRLF. outputLines splits on \n and leaves a trailing \r, so the $ anchored @!@!@Endmsg regex fails to match and a message stays open; readVerdict then sees no rule that broke and the worker exits silently with code 1. Normalize each line in linesOf so every consumer (messages, dot, marks) is CRLF-safe. Fixes cursor#1170.
Author
|
Closing as superseded by #1292 (maintainer's broader CRLF + Windows fix). |
Author
|
Superseded by #1292. Main merged a broader fix for the same root cause: a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Windows JVM writes CRLF.
outputLinesinrun.tssplits on\nand leaves a trailing\r, so the$-anchored@!@!@ENDMSGregex infrontends/messages.tsfails to match and the message never closes.readVerdictthen sees no rule that broke and the worker exits silently with code 1, writing nochart.mmd/report.md.Normalize every line in
linesOf(the shared line-splitting entry infrontends/dot.ts) so all consumers (readMessages,parseDot, marks) are CRLF-safe.Fixes #1170.
Repro (simulated CRLF from the Windows JVM)
Verification
CRLF line endings (Windows JVM) still close @!@!ENDMSG markersasserts LF and CRLF parse identically (8/8 pass inmessages.test.ts).tsc --noEmiton my files: clean (the 4 errors inrun.ts/cli.test.tsare the pre-existing strict-typecheck baseline documented in pstack statechart: strict typecheck reports four errors in run.ts and CLI tests #1141).harness/withscripts/generate-pstack-harness-trees.mjs;--checkpasses.CI
validate-plugins.ymlruns onpstack/**+harness/**and will cover this change.