Skip to content

fix(pstack): scope comment review to the merge-base diff - #1294

Open
flipcyde101 wants to merge 1 commit into
cursor:mainfrom
flipcyde101:work/pstack-comment-scope-1293
Open

flipcyde101 wants to merge 1 commit into
cursor:mainfrom
flipcyde101:work/pstack-comment-scope-1293

Conversation

@flipcyde101

Copy link
Copy Markdown

Fixes #1293.

When a topic branch is behind main, diffing the working tree directly against main can pull unrelated upstream edits into comment review. Both pstack entry points now use the merge base when the caller has not supplied a scope. The default includes the topic commits and staged and unstaged changes to tracked files.

The parent skill now checks a keep against Comment Sicko's documented exceptions, including public API docs and license headers. Regenerated the Claude Code adapter from the same source instructions.

A divergent Git fixture reproduced the scope error and verified the revised commands. The Node 22 plugin validator, generated-tree check, docs checker, and script suite passed on the exact candidate tree (304 passed, 70 skipped).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pstack no-comments: default scope diffs against main instead of the merge-base, and step 2's keep rule contradicts Comment Sicko

1 participant