Repository navigation
fix(pstack): scope comment review to the merge-base diff - #1294
Open
flipcyde101 wants to merge 1 commit into
Open
flipcyde101 wants to merge 1 commit into
flipcyde101 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1293.
When a topic branch is behind main, diffing the working tree directly against main can pull unrelated upstream edits into comment review. Both pstack entry points now use the merge base when the caller has not supplied a scope. The default includes the topic commits and staged and unstaged changes to tracked files.
The parent skill now checks a keep against Comment Sicko's documented exceptions, including public API docs and license headers. Regenerated the Claude Code adapter from the same source instructions.
A divergent Git fixture reproduced the scope error and verified the revised commands. The Node 22 plugin validator, generated-tree check, docs checker, and script suite passed on the exact candidate tree (304 passed, 70 skipped).