Repository navigation
fix(pstack): report statechart actions that made no step - #1303
Open
JasonOA888 wants to merge 1 commit into
Open
JasonOA888 wants to merge 1 commit into
JasonOA888 wants to merge 1 commit into
Conversation
Read TLC verdict-run coverage, group action instances by declaration, and qualify unseen actions when exploration is incomplete. Add guard, warning, early-stop and bounded regression coverage. Refresh TLC recordings and generated harness trees. pstack 0.15.47.
devin-ai-integration
Bot
force-pushed
the
fix/statechart-unfired-actions
branch
from
November 20, 2026 14:06
995abc9 to
ba32603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1235 (level 2: list the actions of
Nextthat made no step). Level 1 (carrying TLC warnings into the report) is in #1254. This PR is independent of it and only touches adjacent lines inreport.ts/run.ts.A rule can be listed under "Rules that hold" when the only action that could break it never fires: a guard that is never true, a constant that disables a branch, or the
UNCHANGEDtypo from #1235. Missing chart arrows can't show this, because the chart can merge, hide, or fall back to bug paths. With the spec from #1235,report.mdnow reads:How
-coverage 0. The newfrontends/coverage.tsreads TLC's next-action summaries (message 2772) and uses the generated-successor counter, so aDoneself-loop counts as a step. It groups parameter instances by declaration and keys on the declaration's location, so same-named actions from different modules stay distinct; the module is printed asMod!Nameonly when names collide.judge()merges coverage across all verdict runs: an action counts as seen if any run generated a successor for it.-lncheck final, and was not cut at the 100,000-stateChartBound. If no run was complete, the report adds:TLC did not explore every reachable state, so these actions may still happen beyond the explored states.Limits (also in SKILL.md)
\Edomain is never instantiated by TLC, so it is not listed.Tests
Vac: the spec from pstack statechart: a rule "holds" when the action that could break it can never fire, and the report drops TLC's warning #1235.FalseGuard: a guard that is never true. TLC prints no warning for it.EarlyCoverage: coverage from a run that stopped early on a violation is not treated as complete.STATECHART_UPDATE=1) because the verdict flags changed. Two existingreport.mdfiles change:CounterInitPastandCounterInitPastHoldsnow sayActions that made no step: Inc., which is correct because their constraints exclude every initial state. Nochart.mmdorgraph.dotchanged. The other recording diffs are the coverage messages plus run metadata (seed, JVM, paths, timestamps).Verification (Linux, Node 24, TLC 2.19 at the pinned hash, JDK 17):
TLA2TOOLS: 431 / 431 passTLA2TOOLS: 322 pass, 0 fail, 73 skippednode scripts/generate-pstack-harness-trees.mjs --check: up to datenode scripts/validate-plugins.mjs: all validnode scripts/check-pstack-docs.mjs: 0 problemsgit diff --check: cleanNot run on macOS or native Windows.