Skip to content

1.4.0 fails to load on Home Assistant 2025.8–2026.2 (Python 3.13): SyntaxError in reader.py #178

Closed

Description

@ogajduse

1.4.0 doesn't import on Python 3.13, which Home Assistant used up to 2026.2 (2026.3 moved to Python 3.14). hacs.json still allows Home Assistant 2025.8.0 and later, so HACS offers 1.4.0 to those users, and the integration then fails to set up:

  File ".../custom_components/feedparser/reader.py", line 329
    except ValueError, OverflowError:
           ^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: multiple exception types must be parenthesized

The unparenthesized form is only valid from Python 3.14 (PEP 758). It came in with #175 (35fb9d8), which changed except (ValueError, OverflowError): on a line unrelated to the proxy. This is probably the formatter, since ruff targets py314. CI only runs on 3.14, so it didn't catch it.

Possible fixes (could do both):

  • Restore the parentheses, and set ruff's target-version to py313 while we support HA before 2026.3.
  • Or raise hacs.json homeassistant to 2026.3.0, so HACS doesn't offer the release to Python 3.13 installs.
  • Add 3.13 to the CI matrix for as long as the minimum allows it.

I have a PR for the first and third point coming up, ready for a 1.4.1.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions