Repository navigation
Skip unused Python HTTP client for explicit kernel connections - #1017
Draft
aakash-saravanan-db wants to merge 1 commit into
Draft
aakash-saravanan-db wants to merge 1 commit into
aakash-saravanan-db wants to merge 1 commit into
Conversation
Signed-off-by: Aakash Saravanan <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
sql.connect(use_kernel=True)builds a Python HTTP client, including SSL setup, even though the Rust kernel uses its own transport.Skip that unused client for explicit kernel connections and handle its absence during setup. Thrift, legacy SEA and automatic fallback keep their existing client.
In an HTTP-only benchmark with 800 concurrent connections, median connect time fell from 7.291 s to 3.369 s. This was a single-run comparison; warehouse warm/load effects were not isolated.
How is this tested?
Unit tests
1,334 unit tests passed (four skipped), plus eight real-kernel tests covering connection lifecycle and sync/async result reads.
Mypy, Black and
git diff --checkpass.Live TLS/proxy and external-cloud validation was not rerun.
Related Tickets & Documents
RE-17633