Repository navigation
GPU TPC: let InterpolationErrors compile as Metal code - #149
Merged
Merged
Conversation
The static constexpr data member added by the merger rebuild is a program-scope variable in MSL, which must be in the constant address space: the Metal IR fails with "program scope variable must reside in constant address space". An enumerator gives the same constant without a variable.
Author
|
@davidrohr as discussed. Notice AliceO2Group#16112 seems to still help (~3%) on Metal. |
davidrohr
reviewed
Nov 21, 2026
|
|
||
| struct InterpolationErrors { | ||
| static constexpr size_t size = constants::MERGER_MAX_TRACK_CLUSTERS; | ||
| enum : uint32_t { size = constants::MERGER_MAX_TRACK_CLUSTERS }; // Not a static data member: Metal and OpenCL allow program-scope variables only in the constant address space |
Owner
There was a problem hiding this comment.
Why do you write metal and OpenCL? With OpenCL this is compiling correctly? In any case, will merge this.
Author
There was a problem hiding this comment.
You are right. Hallucinated from OpenCL 1.0, i guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static constexpr data member added by the merger rebuild is a program-scope variable in MSL, which must be in the constant address space: the Metal IR fails with "program scope variable must reside in constant address space". An enumerator gives the same constant without a variable.