Repository navigation
Conversation
Author
|
The automated review stopped before reviewing the patch because the triggering account needs repository write access. Could a maintainer trigger the label-based review and approve the queued CI? The completed PostgreSQL verification is linked in the PR description. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Highlight the function source returned by
\sfand\sf+using the configured syntax theme. Pass the command context to the output formatter and color the source before laying out psql, plain or expanded output. CSV, TSV, JSONL and markup output retain their existing behavior.Closes #1488. This uses the existing Pygments dependency and the source returned by pgspecial; no server-side or pgspecial change is required.
Validation: 20 focused tests and Ruff check/format pass locally. The hosted Linux/PostgreSQL run passes the complete main test module, real
\sf/\sf+commands, redirected output, output files, repository hooks and changelog validation. The command regression fails on the original source because sf output has no SQL token colors.Stripping colors preserves the previous output, including LF, CRLF and carriage returns in expanded output and automatic expansion. Other display formats keep their existing formatting.
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).