Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1474
Description
Hello, and thank you for maintaining pgcli.
When connecting with
pgcli service=NAME(orPGSERVICE), onlyhost,port,user,dbnameandpasswordwere read from the service entry. Other parameters such assslmode,sslrootcert,sslcertandsslkeywere silently dropped, so the connection was made without SSL, whilepsql service=NAMEworked.This change forwards the remaining parameters of the service entry to the connection, like the URI path already does. A regression test covers the SSL options.
I tested it with
pytest tests/test_main.py -k service(7 passed). The new test fails without the change and passes with it.ruff format --checkis clean.Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).