Repository navigation
Conversation
deploy:update_code uploads the local checkout with rsync -a, which copies the local file modes. CI runners usually check out with umask 0000, so every file in the release ends up 666 and every directory 777, i.e. world writable. Use --no-perms --chmod=ugo=rwX so new files get the remote user's umask, like the default git-based update_code does. Executable bits are kept. Updated docs by running bin/docgen
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/docgen, only line numbers changed)deploy:update_codein the Shopware recipe uploads the local checkout withrsync -azP.-acopies the local file modes, and CI runners usually check out with umask0000, so every file in the release ends up666and every directory (including the release directory)777.This adds
--no-perms --chmod=ugo=rwXto the upload options:--no-permsstops copying the local modes, so new files get the remote user's umask, the same as with the default git-basedupdate_code--chmod=ugo=rwXkeeps executable bits (bin/console, shell scripts) and makes directories traversable before the umask is appliedTested with rsync on files and directories that were
666/777:00027756640022755644Shared dirs and files are not affected; they are symlinked by
deploy:sharedafter the upload.sw:writable:jwtstill sets the JWT keys to660.The same code is in v7.5.12 and v8.0.5. Would you accept a backport to
7.x? If so, I can open a separate PR against that branch.