Repository navigation
Read Muhammad, Achmad and Francisco written short as given names (#1115) - #1117
Merged
Merged
Conversation
Mohd., Mhd. (mul.toml), Muh., Moh., Moch., Ach. (id.toml) and Fco. (es.toml) take a given reading with same_as, so rules/H2's shape yields to them as it does to Chas.: "Mohd. Shameem Khan" gives given 'Mohd.' where 1.4.0 through 2.8.2 gave title 'Mohd.'. Mo. is left out, bare Mo being mostly the Chinese and Korean name. rules/H6 keeps its vocabulary-only reading on a new reason, since #725 removed the Sta./Sto. cost #710 gave: a period-marked word before a family comma is as often a surname's head, a given name written short or a stray period as a title. decisions/H6 records the measurement. Co-Authored-By: Claude Opus 5.5 <[email protected]>
… lines The design-docs review found that the CLDR Excm. renderings predate #701 (corpus_cldr since #654), so #701's "every CLDR case is a listed title" never held; that Sta. Maria still stood as a reason in rules/H6's Because and the Standing line while the Log called the cost removed, and #710's caveat (H2's head shape has no particle stop) had dropped out; that decisions/H2's, vocabulary-model's and rules/H2's lists of the shipped abbreviations were stale; and three counts: 21 of FEC's 31 (not twenty more), 71 on this tree (not 70), and a recipe for the 560-word mining. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1115: its first slice. It covers the given names written short and the new reason for rules/H6. The title batches, the defaults for the pack-only degrees, the exclusions and the Diplom degrees come later.
What changes
Given names written short. Seven words get a
givenreading withsame_as, so rules/H2's leading-abbreviation shape yields to them as it does toChas.(#789):mohd,mhdmuh,moh,mochachfcoEach word's ORCID box counts are on its entry.
mois left out. 45 corpus names writeMo.for Muhammad (42 of them Nepalese candidates), but bareMois mostly the Chinese and Korean name (ORCID family boxes 3,478, China 952). Agivenreading would makeReading.languagesreport a Mo Yan's given name as read in the file holding the word.Md.keeps its 2026-10-27 reading (decisions/indic-honorifics).rules/H6 (a title before a family comma) keeps its vocabulary-only run, on a new reason. #710's reason was the
Sta. Mariacost, and #725 removed it by makingsta/stosaint particles, which the run already stops at. A scan of what a shape peel would reach (72 names ondd2650ef) finds the reason that remains. A period-marked word before a family comma is as often a given name written short (Md. Abu Shahin, FCPS, MD), a stray period on a name word (BEUMLER. WEAVER, CAROL) or a surname's head that is no particle (MT. PLEASANT, JANE) as it is a title. So titles get listed, and slips read wherever the rules put them. decisions/H6 records the measurements, and #710's caveat stands: H2's head shape has no particle stop.Measured
uv run python tools/differential/config_diff.py diff --local all --committed --match '(?i)\b(mohd|muh|moh|mhd|moch|ach|fco)\b' '<the tree without the seven readings>' default, 2026-11-06 against0a4233f1. 125 of the 3,089 matching names move:Mohd. Abu Bakar Siddique→ family 'Abu Bakar Siddique'), the cost decisions/indic-honorifics accepts forMd Abu SayedA sweep of 16 shapes × 3 name orders for
Mohd,MuhandFcomoved names only where H2's shape had fired (the head of the given part). Under the family-first orders the word is then placed by position, asChas.is. Nothing moved in the trailing, bare or before-a-family-comma positions.The committed snapshot gains one name (
Mt. Pleasant, Jane, a new H6 boundary row) and moves none.Review
The design-docs review ran all twelve axes and found six problems, all fixed in the second commit:
Excm.names predateDr. Smith, Johnreads familyDr. Smith: a title before a family comma isn't peeled #701, soDr. Smith, Johnreads familyDr. Smith: a title before a family comma isn't peeled #701's "every CLDR case is a listed title" never held (the Which abbreviations that open a name should the vocabulary list:Excm.,Mohd.,Mt.? #1115 issue body repeats the wrong Read the field and the comma from what stands beside it: H1 behind a comma (#720), C12 (#656) #735 attribution)Sta. Mariastill stood as a reason in H6's BecauseTest plan
uv run pytest(39,051 passed) anduv run pytest -n0 -m serialuv run mypy,uv run ruff checkuv run sphinx-build -b doctest docsand the html build🤖 Generated with Claude Code