Repository navigation
Read the pack titles no name bears by default (#1115) - #1121
Merged
Merged
Conversation
Phase 3g, phase 3f and #1108 wrote the Spanish, Portuguese, Czech, Slovak and Vietnamese titles default = false so phase 3 moved no default parse, not for a collision. 27 of them now read by default (lic, licenciado, mtro, doctora, doutor, professora, JUDr, MUDr, PhDr, RNDr, ThS, ĐBQH, ...), and nine titles the mining found unlisted join on by default (licda, profr, gral, tte, RSDr, ThLic, ThMgr, plk, npor). The words a name or initials spell stay the packs': maestra, doña, MgA, BcA, pan, GS, TS, PGS. 312 of 8,529 matching corpus names move, 219 in Mexico's DOF signatures. The locale tests that held each word as a choice's now hold the pack reading it as the default does; the tests that used lic and judr as choice-only words use maestra and mga. docs/locales.rst, the pack docstrings and the 3.0 release bullets follow. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The design-docs review found decisions/vocabulary-model's Standing line for phase 3g still listing the titles now read by default, the new line pointing at it by position, and phases 3f, 3g and #1108 left without head notes; locales.rst overstating where a bare doctorate is a title (a bare title ending a name stays a name word); the CLI example in usage.rst and __main__ still showing Lic as pack vocabulary; the Slavic pack test left with no pack-only academic title, now walked with MgA in its shapes; "27 readings" for 27 words and 36 readings; the cost list missing 14 Czech doctorates moved from suffix to title, a credential moved into the family and lic psych's given name; and the notes and locales.rst saying no name bears Doctora, Licenciado and Lic, each borne once as a family name. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1115, the pack-titles batch. Phase 3g, phase 3f and #1108 wrote the Spanish, Portuguese, Czech, Slovak and Vietnamese titles
default = falseso that phase 3 moved no default parse, not because of a collision. #804 made that default change forprofesor. This PR makes it for the rest that no name or initials spell.What changes
Read by default: 27 words, 36 readings. The nine doctorates have readings in both cs.toml and sk.toml.
lic,licenciado,licenciada,lcdo,lcda,ingeniero,ingeniera,arq,mtro,mtra,doctoradoutor,doutora,professora,profajudr,mudr,phdr,rndr,mvdr,mddr,paeddr,pharmdr,thdrths,đbqh,dbqhListed, on by default:
licda,profr,gral,tte(es) andrsdr,thlic,thmgr,plk,npor(cs). None has name bearers.Kept the choice's, each read against its moves:
maestra: a schoolteacher and a family namedoña: a family namemga: Sri Lankan initialsMGAbca: an English credentialpan, andmgr's degree readinggs,ts,pgs: written as initials (NGO, TSwould lose its given name)Measured
config_diff.py diff --local all --committedagainst the tree without the readings, 2026-11-06 one6a86bc9. 312 of the 8,529 matching names move:plk.v.v.and 10 licentiates (Teemu Elomaa, Lic.Med)Other costs, recorded in decisions/vocabulary-model's 2026-11-06 #1115 entry:
Doctora en Neumologíaleavesenas the given nameLic.Yiliantakes the glued name word, asDr.doesDoctora,LicenciadoandLicare each borne once as a family name in ORCID or PatentsView, none written first)The snapshot moves one committed name (
ĐBQH Nguyễn Văn Anh), and its CLDR record is re-recorded: the family and given names now agree with CLDR, and the title disagrees.Tests and docs
_READ_BY_DEFAULT_SINCE_1115, which asserts that the default reads each row as its pack does.licorjudras a pack-only word and now usemaestraandmga. Each was checked to read under the pack and the default as the old word did on master.MgArows in each comma shape, order and case.Review
The design-docs review recomputed 312, 8,529, the per-source split and the licentiate count, all exact. It read all 93 moves outside DOF and found no real name eaten, and confirmed both release examples against the 1.4.0, 2.8.0 and 2.8.2 wheels. It found eight problems, all fixed in the second commit:
parser_for(locales.VI)readNguyen Van Anhas family Nguyen, middle Van, given Anh, andLe Van Anhas family Le? #1108 entriesTest plan
uv run pytest(39,122 passed) anduv run pytest -n0 -m serialuv run mypy,uv run ruff check,python -m doctest README.rstuv run sphinx-build -b doctest docs🤖 Generated with Claude Code