Repository navigation
List dipl, the diploma degree, as a title (#1115) - #1123
Merged
Merged
Conversation
dipl (mul.toml, academic) is listed alone; the period-joined chunk rule that reads Lt.Gov. then reads every field written after it with a period as a title: Dipl.-Psych., Dipl.-Kfm., Dipl.Ing., dipl.um. "Anselm Crombach, Dipl.-Psych." no longer reverses into given 'Dipl.-Psych.', family 'Anselm Crombach'. 58 of 160 corpus names move. The separator match proposed on #1115 is declined as unneeded. Left: a field joined by a hyphen alone (Dipl-Psych), the spaced periodless form, and a spaced degree in a post-nominal run, whose field splits off (dipl. stom., CLDR's Bosnian rendering, re-recorded). Co-Authored-By: Claude Opus 5.5 <[email protected]>
#1115) The design-docs review found that listing dipl moves a degree glued to its field and ending a name with no comma from the suffix to the family (Maxie Bunz Dipl.Psych. -> family 'Dipl.Psych.', middle 'Bunz'): the chunk verdict is now the title, and H5's trailing run reads no word with an interior period. No corpus name is written so; accepted here, as Lt.Gov. already reads, and added to #1116. rules/S3 now states that a title chunk is read before the suffix chunks (an Except bullet) and records the trailing case (an Accepted bullet). The entry gains the two cut credential runs, the six spaced fields without a period (four read so before), the 20 officials beside the 19 moved, and drops an unreproducible spelling count; dipl's note records the English Diplomate. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The second-round review of the S3 bullets found the Except's lead false for a word listed whole (Dr.PH, MS.Ed. read as their listed credential, the chunk test never asked), stated for every slot where the title reading holds only before the name and after a comma, and argued for the degrees while reaching every title chunk. The Except now names the whole-word listing first (a Dr.PH boundary row) and its slots; the Accepted bullet covers the given part after a family comma, which this PR moved from suffix to middle (Doe, John Dipl.Ing.), and the name's inside; a second Accepted bullet records the duals and Saint the chunk reaches (MD.MS, St.John). Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1115, the Diplom degrees.
What changes
diplis listed alone (mul.toml, academic). A token whose chunks a period joins already reads as a title when any chunk is a title (v1's rule forLt.Gov.), so every field written afterDiplwith a period now reads as one, whatever the field:The per-compound listing and the separator-insensitive match proposed on #1115 are declined as unneeded. rules/S3 now states the title-chunk reading, which v1 had but no rule stated. An Except bullet says a period-joined word the vocabulary does not list whole is a title before the name and after a comma when any chunk is a title, read before its suffix chunks (
Dr.PHstays its listed credential). An Accepted bullet records the readings that reach beyond the degrees (MD.MS,St.John).Measured
160 corpus names hold
diplas a word; 58 move (2026-11-06,8c1cc709):Name, Dipl.-Psych.stop reversing)Costs, in decisions/H6's 2026-11-06 Diplom entry:
dipl. stom.among them; its agreement record is re-recorded);or&behind (2)Dr.does (1)Maxie Bunz Dipl.Psych.→ family 'Dipl.Psych.', middle 'Bunz'), and after a family comma a middle name (Doe, John Dipl.Ing.). No corpus name withDipltakes either shape, and it is whatJohn Smith Lt.Gov.already gives. It is accepted here and recorded as rules/S3's Accepted bullet, and ShouldHans Meier Priv.-Doz.read the listed title at the end, asHans Meier Prof.does? #1116 is widened to cover both shapes, since its fix to H5's trailing run reaches them.Left as they read: a field joined by a hyphen alone (
Dipl-Psych, 3), since the chunk rule splits at periods only and hyphenated surnames hold title words; a spaced field without its period (Dipl. Biol,Dipl Ing, 6); and the spaced form before a family comma (1).Review
The design-docs review confirmed the 160/58/34/24 measurement, read every moved name, swept every comma shape and order, checked the case views and checked the release claim against eleven wheels from 1.4.0 to 2.8.2. It found the trailing regression above, S3's missing title-chunk precedence, two cut credential runs, an undercount of the spaced-field leftovers, the 20 writers behind the 19 moves, and an unreproducible spelling count. All are fixed in the second commit. A second-round review of that commit's S3 bullets found the Except's lead false for a word listed whole, unscoped by slot, and wider than its argument, plus the family-comma move above; all are fixed in the third commit.
Test plan
uv run pytest(39,190 passed) anduv run pytest -n0 -m serialuv run mypy,uv run ruff checkuv run sphinx-build -b doctest docsand the html build🤖 Generated with Claude Code