Repository navigation
docs: fix --add-host example to run HTTP server in background - #7518
Open
indraoverflow wants to merge 1 commit into
Open
indraoverflow wants to merge 1 commit into
indraoverflow wants to merge 1 commit into
Conversation
Fixes docker#5558 The example for the --add-host flag with host-gateway ran the Python HTTP server in the foreground, preventing the user from running the docker command in the same terminal. This change runs the server in the background and kills it after the curl command completes. Signed-off-by: Indra Prasetya <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The example for the
--add-hostflag withhost-gatewayran the Python HTTP server in the foreground, preventing the user from running thedocker runcommand in the same terminal. This change runs the server in the background and kills it after thecurlcommand completes.Verification
[1] 12345) and useskill %1to stop the server after the curl command.Issue Reference
Fixes #5558
Checklist
Type of Change
An agent wrote it under close human direction.