Repository navigation
fix(phone): hide the footer chips while a status pill shows - #72
Merged
Merged
Conversation
The phone status pill spans the docked bar's width 8px above it, in the band where the presence and Discord/GitHub/Privacy chips float, so a refused "/" pick, a removed format's Undo or an unavailable cell's reason covered them. Hide the chips while the bar holds a pill, as they already hide for the selection bar; they come back when it closes.
# Conflicts: # CHANGELOG.md
A "/" typed while an earlier fetch of the menu chunk was still failing (the chunk runtime fetches a failed chunk once more, a moment later) joined that fetch. When it failed, nothing loaded the chunk again while the menu stayed open, so the menu never showed even once the chunk could load. A failed load is now fetched once more straight away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
At 375 px (and 320 px) the phone status pill covered the presence chip and the Discord / GitHub / Privacy chips at the bottom right: a refused "/" pick, a removed format's Undo (once the sheet closes), or an unavailable cell's reason all landed on top of them.
The footer chips now hide while a status pill shows on the docked bar, the same way they already hide while the selection bar shows. They come back when the pill closes. This is CSS only, in the lazy phone chunk (
components/smart-toolbar/phone/phone.scss):The pill keeps the placement design pass §5 gives it (8 px above the bar, full width). The §5 phone bullet now says the chips also hide while a pill shows on the bar.
Root cause
On a phone the pill is
absolute inset-x-2 bottom-[calc(100%+8px)]inside the bar, so it spans the viewport width 8 px above the bar. The chips are fixed atbottom: calc(var(--mobile-bar-clearance) + 0.5rem), which is the same band. §5 had only covered the selection-bar case. In the default bar, the pill (z-50) sat on top of the chips (z-30) and covered part of them.How verified
tests/e2e/mobile-bar.spec.ts("status pill and footer chips at 375px / 320px"). As a touch phone, it checks that the chips are visible, puts the selection in code in the normal bar, and taps the unavailable Bold so its reason shows on the pill. After the enter animation,expect.pollchecks that no visible chip card intersects the pill's rect. It then checks that the chips come back once the pill closes.--repeat-each=5(Chromium) and--repeat-each=3(WebKit, together with the existing selection-bar chips test).mobile-bar,mobile-bar-followups,paint-format,continue-chip,toolbar-a11y-r3(113 passed, 1 skipped).bun run check,bun run lint,bun run typecheckandbun run testpass.bun run checkreports pre-existing warnings only. One unrelated unit test failed once and passed on rerun.Bundle budgets
PALETTE_BUDGETwas not run.Follow-ups (non-blocking)
tests/TESTING.mdhas nomobile-bar.spec.tsrow, so this PR has no row to update. A row for the spec is worth adding separately.