Repository navigation
Conversation
A starter entry can describe the engines that run its backend: local PHP with SQLite, DDEV, Lando, or a Drupal that already exists. - drx init asks for the engine, or takes it from a flag, and checks that the engine's commands are on the machine. - It removes the files of the engines not chosen, writes the backend URL, and records the choice in drx.config.json. - The quickstart entry describes its three engines, and keeps its local tooling whatever engine is chosen. - drx.config.json is read from disk on every load.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Decipher
force-pushed
the
feature/04-engines
branch
from
November 18, 2026 06:51
c76e492 to
8820aae
Compare
The quoted `cd` line meets the engine's steps this branch prints after it, and keeps both. The repeated read of drx.config.json was already here, with its test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
drx initchooses the engine that runs the backend.noneis for a Drupal that already exists.drx inittakes--engine, or asks. It checks that the engine's commands are on the machine and removes the files of the engines not chosen. It then writes the backend URL and records the choice indrx.config.json.drx.config.jsonis read from disk on each load, so a change made by one step is seen by the next.initremoves and the recorded choice.Why
The quickstart holds the files of several ways to run Drupal, and a new site needs one of them. Choosing at
initleaves a site with one engine's files, and gives later commands a recorded answer to "how is the backend run here".How it was checked
npm run lintandnpm run typecheckpassnpm testpasses, and coverage did not dropRun from a clean
npm ci: eachrun:line of the workflow's lint and test jobs,yamllint,actionlintandnpm run build.npm testran 403 tests, above the floor. The pack step ran as the workflow has it, from the installed binaries.Not covered yet
initprints follow the quickstart's README.--setupanswers "not available yet".