Repository navigation
refactor: replace the deprecated breakpoint ruler actions in the Check, Check Configuration and Format UIs - #1618
Open
joaodinissf wants to merge 3 commits into
Open
joaodinissf wants to merge 3 commits into
joaodinissf wants to merge 3 commits into
Conversation
joaodinissf
marked this pull request as ready for review
November 6, 2026 00:54
Collaborator
Author
|
We're reworking this, so it doesn't need a review as it is. Moving it back to draft. Posted by Claude Code on behalf of @joaodinissf. |
joaodinissf
marked this pull request as draft
November 6, 2026 07:45
Member
|
I wonder if this is true. If it is so that Xtext writes block unconditionally that point to deprecated stuff, probably a PR for Xtext is better |
joaodinissf
force-pushed
the
chore/ignore-deprecated-ui-extensions
branch
from
November 21, 2026 15:05
c42ca4b to
8462b20
Compare
Collaborator
Author
|
You were right: suppressing the warnings was the wrong fix. I've reworked the PR to replace each deprecated entry with its supported equivalent, so nothing is ignored any more. The root cause is in Xtext: (Comment left by Claude at João's request.) |
joaodinissf
marked this pull request as ready for review
November 21, 2026 15:05
The Check Configuration UI registered the Xbase breakpoint adapter and the ruler actions that the Xtext generator emits for every Xbase language, on the deprecated org.eclipse.ui.editorActions and org.eclipse.ui.popupMenus extension points. A check configuration infers no executable code, so a breakpoint in it can never be hit. The adapter and both ruler contributions are removed; the editor ruler no longer offers to toggle breakpoints. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The Check and Format UIs contributed their ruler breakpoint actions the way the Xtext generator emits them for Xbase languages: action delegates on the deprecated org.eclipse.ui.editorActions and org.eclipse.ui.popupMenus extension points. A new BreakpointRulerActionContributor in com.avaloq.tools.ddk.xtext.ui is an Xtext IActionContributor that installs the public debug UI ToggleBreakpointAction as the ruler double-click action, plus enable or disable and properties actions built on RulerBreakpointAction. A BreakpointRulerMenu dynamic contribution on org.eclipse.ui.menus shows the three actions in the ruler context menu. Both UI modules bind the contributor. The breakpoint adapter that creates the breakpoints is unchanged. Behaviour is unchanged apart from the enable or disable and properties menu labels, which no longer show the modifier-click hints of the JDT delegates. com.avaloq.tools.ddk.xtext.ui gains optional dependencies on org.eclipse.debug.core and org.eclipse.debug.ui. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ck Configuration editors BreakpointRulerActionsTest opens Check, Format and Check Configuration editors and checks which ruler actions and ruler menu entries each one gets, and that the enable or disable and properties actions follow a breakpoint on the ruler line. Co-Authored-By: Claude Opus 5.5 <[email protected]>
joaodinissf
force-pushed
the
chore/ignore-deprecated-ui-extensions
branch
from
November 21, 2026 15:37
8462b20 to
6e8e29e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 24 PDE warnings on the deprecated
org.eclipse.ui.editorActionsandorg.eclipse.ui.popupMenusextension points incheck.ui,checkcfg.uiandxtext.format.ui. Nothing is suppressed.Where the warnings come from
Xtext's
XbaseGeneratorFragment2writes the same block for every Xbase language: action delegates for the ruler double-click, toggle, enable or disable and properties. That is 8 warnings per bundle. The generator has no option to leave the block out, and Xtext's own Xbase languages and examples still carry it.The 3 remaining warnings come from the Deploy and Undeploy menu in
check.ui. They are left to a separate PR that removes the unused Check project support.The change
One commit per part:
Check Configuration loses its breakpoint adapter and ruler actions. A check configuration infers no executable code, so a breakpoint in it could never be hit.
Check and Format install their ruler actions in code. A new
BreakpointRulerActionContributorinxtext.uiis an XtextIActionContributor:ToggleBreakpointActionas the ruler double-click action;RulerBreakpointAction.A
BreakpointRulerMenudynamic contribution shows the three actions in the ruler menu. Both UI modules bind the contributor. The breakpoint adapter that creates the breakpoints is unchanged.Tests for the ruler actions of all three editors.
xtext.uigains optional dependencies onorg.eclipse.debug.coreandorg.eclipse.debug.ui.xtext.ui,check.ui,checkcfg.uiandxtext.format.uiget a micro version bump.Behaviour changes
.checkcfgeditor no longer offers breakpoints.plugin.xml_genkeeps the generated deprecated block.plugin.xmlis maintained by hand, and regenerating with the CheckCfg workflow left it unchanged.Testing
clean verifywithcheckstyle:check,pmd:check,pmd:cpd-checkandspotbugs:checkpasses, including the version baseline check. 494 tests ran with no failures or errors, and 2 were skipped.🤖 Generated with Claude Code