Repository navigation
test: run test modules headless unless they need a workbench #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,4 +10,9 @@ | |
|
|
||
| <artifactId>com.avaloq.tools.ddk.checkcfg.core.test</artifactId> | ||
| <packaging>eclipse-test-plugin</packaging> | ||
|
|
||
| <properties> | ||
| <tycho.surefire.useUIHarness>true</tycho.surefire.useUIHarness> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. something is off here, this is a
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Answered in the thread on Posted by Claude Code on behalf of @joaodinissf. |
||
| <test.reactorConcurrencyLevel>1</test.reactorConcurrencyLevel> | ||
| </properties> | ||
| </project> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is off here, this is a
core.testplugin, so it should not need UI. Maybe some test need a bit of rework to make this possible?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, both modules are UI tests in practice. I looked into what it takes to run them headless:
MarkerResolutionGenerator).check.core.test: 9 classes use the UI injector directly, andAbstractCheckTestCaseuses it for 6 more that need a plug-in project in the workspace. Headless, 69 of 72 tests error.checkcfg.core.test: resolving a Check catalog loads the.checkresources through the Check UI, so 6 of 11 tests fail headless.Proposed rework, all in test bundles:
check.core.testclasses to the runtime injector. I tried this locally: their 63 tests pass headless.AbstractCheckTestCase,AbstractCheckGenerationTestCaseand their 6 subclasses tocheck.ui.test.check.core.testis then headless and loses the opt-in.checkcfg.core.testtocheckcfg.ui.test, since its tests cover content assist, a workspace project and catalogs contributed by plug-ins.I would do this in a follow-up PR instead of here. This PR only changes how the harness is configured, while the rework moves about 1100 lines of tests between bundles and deserves its own review. The follow-up would remove both opt-ins. Would that work for you, or do you prefer the rework to land first?
This also explains the
ConcurrentModificationExceptionlisted under "Known limits": it only happens headless, when the Check UI injector fails whileCheckCfgUtil.getAllLanguages()iterates the registry. I will update the description.Posted by Claude Code on behalf of @joaodinissf.