Repository navigation
test: run check.core.test headless and rename checkcfg.core.test to checkcfg.ui.test - #1640
Open
joaodinissf wants to merge 2 commits into
Open
joaodinissf wants to merge 2 commits into
joaodinissf wants to merge 2 commits into
Conversation
The module needed a workbench only because most of its tests asked for the Check UI injector, which cannot be created without one: check.ui's SharedUiModule binds MarkerResolutionGenerator, which injects IWorkbench. - Six test classes use the runtime injector through the existing RegistryIsolatingCheckInjectorProvider. They never needed the UI module. - AbstractCheckGenerationTestCase no longer extends AbstractCheckTestCase. Its tests generate and compile in memory and never used the workspace project that the base class created. - AbstractCheckTestCase, ProjectBasedTests and CheckScopingTest move to check.ui.test, package com.avaloq.tools.ddk.check.ui.test. They create a plug-in project in the workspace and need the UI injector. Their fixtures stay in check.core.test, where BugDsl27Test and BugAig1314Test share them. - check.core.test drops its UI dependencies, its stale generated CheckUiInjectorProvider and its workbench opt-in. - check.test.runtime.tests and sample.helloworld.ui.test take AbstractCheckTestCase from check.ui.test. Co-Authored-By: Claude Fable 5.2 <[email protected]>
All of its tests depend on what only UI bundles register: the languages and Check catalogs contributed through the extension registry, a workspace plug-in project, and content assist. It keeps its workbench opt-in, and the name now says why. Co-Authored-By: Claude Fable 5.2 <[email protected]>
joaodinissf
force-pushed
the
core-tests-headless-step-3
branch
from
November 20, 2026 16:54
a518789 to
c9efb3d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check.core.testruns without a workbench, andcheckcfg.core.testis renamed tocheckcfg.ui.test. Acore.testmodule no longer needs the UI harness.Stacked on #1622: this PR contains only the two commits on top of it.
Why these modules needed a workbench
Most of their tests asked for the language's UI injector. The Check UI injector can't be created without a workbench:
check.uiinstallsSharedUiModule, which bindsMarkerResolutionGenerator, and that class injectsIWorkbench.check.core.testRegistryIsolatingCheckInjectorProvider:CheckValidationTest,CheckJavaValidatorUtilTest,BasicModelTest,CheckFormattingTest,CheckApiAccessValidationsTest,BugAig830Test. They exercise the runtime module now, not the UI module's overrides.AbstractCheckGenerationTestCaseno longer extendsAbstractCheckTestCase. Its four test classes generate and compile in memory and never used the workspace project the base class created.AbstractCheckTestCase,ProjectBasedTestsandCheckScopingTestmove tocheck.ui.test, packagecom.avaloq.tools.ddk.check.ui.test. They create a plug-in project in the workspace, which needs the UI injector. Their fixtures stay incheck.core.test, whereBugDsl27TestandBugAig1314Testshare them.CheckUiInjectorProviderand its workbench opt-in.check.test.runtime.testsandsample.helloworld.ui.testtakeAbstractCheckTestCasefromcheck.ui.test.checkcfg.core.test→checkcfg.ui.testAll 11 tests depend on what only UI bundles register: languages and Check catalogs from the extension registry, a workspace plug-in project, and content assist. The module keeps its workbench opt-in, and its packages are unchanged.
Compatibility
AbstractCheckTestCasechanges bundle and package. Code outside this repository that extends it needs the new import and a dependency oncom.avaloq.tools.ddk.check.ui.test.com.avaloq.tools.ddk.checkcfg.core.testis nowcom.avaloq.tools.ddk.checkcfg.ui.test.Validation
./mvnw -U -T 3C clean verify checkstyle:check pmd:pmd pmd:cpd pmd:check pmd:cpd-check spotbugs:check -f ddk-parent/pom.xml --batch-mode --fail-at-endpasses locally on this commit (macOS, Temurin 21): 490 tests, 2 skipped.check.ui.test.check.core.testruns 73 tests under the headless harness. 8 modules run headless and 6 start a workbench.check.ui.testnow runs the two moved test classes beforeCheckQuickfixTest. It passed 10 of 10 serial runs, as did test: run test modules headless unless they need a workbench #1622's head. Before those,testBulkApplyingQuickfixtimed out in 2 of 3 runs of this change, one of them under-T 3C; that timeout did not recur.🤖 Generated with Claude Code