Repository navigation
fix: remove the unused Check project support from the Check UI - #1643
Draft
joaodinissf wants to merge 1 commit into
Draft
joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
The Check project and file wizards were removed in #1298, but their registrations stayed in plugin.xml, so File > New offered wizards that fail to start. Nothing in DDK adds the Check nature any more, so the Deploy and Undeploy menu, its jobs and the nature have no users either. Remove the wizard registrations, the Deploy and Undeploy menu with its actions, jobs, ProjectUtil and messages, the Check nature and its extension, and the checkcfg.core dependency that only the deploy job used. This also removes the last 3 deprecated popupMenus warnings in check.ui. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Check project support that is left over after the wizards were removed in #1298.
Note
Draft until we confirm that no downstream project still relies on the Check nature or the Deploy and Undeploy menu.
What is removed from
check.uipopupMenusobject contribution, the two actions, their jobs,ProjectUtiland the bundle'sMessages, which only these actions used.CheckNatureand itsorg.eclipse.core.resources.naturesextension). Nothing in DDK adds it any more.com.avaloq.tools.ddk.checkcfg.coredependency, which only the deploy job used.This also removes the 3 deprecated
popupMenuswarnings from the Deploy and Undeploy menu.check.uigets a micro version bump.Compatibility
A workspace project that still lists
com.avaloq.tools.ddk.check.ui.CheckNaturein its.projectkeeps working. The nature is no longer defined, so it is ignored, and the project loses only the Deploy and Undeploy menu.Testing
clean verifywithcheckstyle:check,pmd:check,pmd:cpd-checkandspotbugs:checkpasses, including the version baseline check. 490 tests ran with no failures or errors, and 2 were skipped.🤖 Generated with Claude Code