Skip to content

fix: remove the unused Check project support from the Check UI - #1643

Draft
joaodinissf wants to merge 1 commit into
masterfrom
fix/remove-stale-check-wizards
Draft

joaodinissf wants to merge 1 commit into
masterfrom
fix/remove-stale-check-wizards

Conversation

@joaodinissf

Copy link
Copy Markdown
Collaborator

Removes the Check project support that is left over after the wizards were removed in #1298.

Note

Draft until we confirm that no downstream project still relies on the Check nature or the Deploy and Undeploy menu.

What is removed from check.ui

  • The new-project and new-file wizard registrations. Their classes were removed in feat: remove wizards for created checks #1298, so File > New offered two wizards that fail with "The selected wizard could not be started".
  • The Deploy and Undeploy menu for Check projects: the popupMenus object contribution, the two actions, their jobs, ProjectUtil and the bundle's Messages, which only these actions used.
  • The Check nature (CheckNature and its org.eclipse.core.resources.natures extension). Nothing in DDK adds it any more.
  • The com.avaloq.tools.ddk.checkcfg.core dependency, which only the deploy job used.

This also removes the 3 deprecated popupMenus warnings from the Deploy and Undeploy menu. check.ui gets a micro version bump.

Compatibility

A workspace project that still lists com.avaloq.tools.ddk.check.ui.CheckNature in its .project keeps working. The nature is no longer defined, so it is ignored, and the project loses only the Deploy and Undeploy menu.

Testing

  • Maven on this branch, with Temurin 21: clean verify with checkstyle:check, pmd:check, pmd:cpd-check and spotbugs:check passes, including the version baseline check. 490 tests ran with no failures or errors, and 2 were skipped.

🤖 Generated with Claude Code

The Check project and file wizards were removed in #1298, but their
registrations stayed in plugin.xml, so File > New offered wizards that
fail to start. Nothing in DDK adds the Check nature any more, so the
Deploy and Undeploy menu, its jobs and the nature have no users either.

Remove the wizard registrations, the Deploy and Undeploy menu with its
actions, jobs, ProjectUtil and messages, the Check nature and its
extension, and the checkcfg.core dependency that only the deploy job
used. This also removes the last 3 deprecated popupMenus warnings in
check.ui.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant