Repository navigation
fix: stop the Format workflow from generating Xtend stubs - #1645
Open
joaodinissf wants to merge 1 commit into
Open
joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
GenerateFormat.mwe2 uses StandardLanguage without preferXtendStubs = false, unlike the other DDK workflows, so every regeneration wrote .xtend stubs next to the hand-written Java classes: the runtime, UI and IDE modules, the standalone and IDE setups, the scope provider, the validator and the parsing test. Set preferXtendStubs = false in the code configuration. The JUnit fragment sets its own Xtend default, so also turn it off on junitSupport. All the stubbed classes already exist in Java, so nothing new is generated. Co-Authored-By: Claude Opus 5.5 <[email protected]>
joaodinissf
marked this pull request as ready for review
November 21, 2026 20:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops
GenerateFormat.mwe2from writing.xtendstubs next to the hand-written Java classes of the Format language.The change
The Format workflow uses
StandardLanguageand, unlike the other DDK workflows, did not setpreferXtendStubs = false. Every regeneration therefore wrote eight.xtendstubs:FormatRuntimeModule,FormatStandaloneSetup,FormatScopeProviderandFormatValidatorinxtext.format;FormatIdeModuleandFormatIdeSetupinxtext.format.ide;FormatUiModuleinxtext.format.ui;FormatParsingTestinxtext.format.test.This PR sets
preferXtendStubs = falsein the code configuration. The JUnit fragment sets its own Xtend default, sojunitSupportalso getsgenerateXtendStub = false. Every stubbed class already exists in Java, so no new file is generated and no binding changes.Only the workflow changes, so no bundle version is bumped.
Testing
GenerateFormat.mwe2, none of the eight stubs appears. Together with fix: stop the workflows from generating Xtend inferrer stubs #1644, the workflow writes no.xtendfile at all.clean verifywithcheckstyle:check,pmd:check,pmd:cpd-checkandspotbugs:checkpasses. 490 tests ran with no failures or errors, and 2 were skipped.🤖 Generated with Claude Code