Repository navigation
Show on-demand hyperlinks sooner after the mouse rests - #4583
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #4410, on-demand hyperlink detection waits until the mouse has rested for 200 ms while the modifier is held, and every mouse move restarts that timer. On macOS the pointer keeps reporting moves while it stays within the same character, so the link appears late or not at all until the pointer is completely still. Detection is now only rescheduled when the text offset under the mouse changes, and the rest delay is lowered to 30 ms. A key press such as Ctrl+C cancels a pending detection, but held keys are deliberately not tracked: moving the pointer while Ctrl+C is still down can detect after the delay, because tracking key state across widgets added more edge cases than it prevented.
Fixes eclipse-platform/eclipse.platform.swt#3879