Repository navigation
Conversation
On macOS in dark mode GC.copyArea() from a widget captures the window background (RGB 28,28,28) instead of the widget background (RGB 30,30,30), so every scanned pixel looked painted. Rendering the widget with print() into an offscreen image uses the widget's own background at any appearance and zoom. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Test Results 867 files ±0 867 suites ±0 45m 46s ⏱️ - 5m 13s For more details on these failures, see this check. Results for commit d6c325d. ± Comparison against base commit b5dd338. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three CodeMiningTest tests and LineContentBoundsDrawingTest.testTextBoundsMatchPaintedArea fail on macOS in dark mode, also on master. There, GC.copyArea() from a widget captures the window material (RGB 28,28,28) instead of the StyledText background (RGB 30,30,30), so every scanned pixel counts as painted. The scans now render the widget with print() into an offscreen image, the same approach the existing printWidget helper already uses for the footer code mining test. This makes the tests independent of the system appearance and of whether the window is in front, without changing what they assert.