Skip to content

Activate the test shell before content assist auto activation - #4585

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:fix-async-content-assist-flake
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:fix-async-content-assist-flake

Conversation

@vogella

@vogella vogella commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Three AsyncContentAssistTest tests (testCompleteActivationChar, testNoAutoInsertOnAutoActivation, testNoAutoInsertOnCompletionOnType) fail intermittently on macOS with "Not unique new shell found". Auto activation shows the popup from a syncExec that silently returns when the text widget is not the focus control (ContentAssistant.java:402), and forceFocus() cannot give it focus while another application is active, which is why the failures show up when the machine is in use. The tests now call shell.forceActive() again before focusing the widget, which e22534a dropped together with Display.post(). findNewShell also pumps the event loop until the popup shell exists instead of checking every 100 ms, so it reacts as soon as the popup opens.

Auto activation drops the request when the text widget is not the focus
control, and on macOS forceFocus() alone cannot give it focus while the
test shell is not active, so no proposal popup appeared. Restore the
shell.forceActive() call that e22534a dropped, and let findNewShell
pump the event loop until the popup exists instead of fixed sleeps.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   58m 6s ⏱️ + 7m 7s
 8 548 tests ±0   8 308 ✅ ±0  240 💤 ±0  0 ❌ ±0 
21 516 runs  ±0  20 843 ✅ ±0  673 💤 ±0  0 ❌ ±0 

Results for commit 1e51d9f. ± Comparison against base commit b5dd338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant