Repository navigation
Conversation
Auto activation drops the request when the text widget is not the focus control, and on macOS forceFocus() alone cannot give it focus while the test shell is not active, so no proposal popup appeared. Restore the shell.forceActive() call that e22534a dropped, and let findNewShell pump the event loop until the popup exists instead of fixed sleeps. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three AsyncContentAssistTest tests (testCompleteActivationChar, testNoAutoInsertOnAutoActivation, testNoAutoInsertOnCompletionOnType) fail intermittently on macOS with "Not unique new shell found". Auto activation shows the popup from a syncExec that silently returns when the text widget is not the focus control (ContentAssistant.java:402), and forceFocus() cannot give it focus while another application is active, which is why the failures show up when the machine is in use. The tests now call shell.forceActive() again before focusing the widget, which e22534a dropped together with Display.post(). findNewShell also pumps the event loop until the popup shell exists instead of checking every 100 ms, so it reacts as soon as the popup opens.