Repository navigation
Improve diff highlight contrast in Eclipse dark theme - #2995
tobiasmelcher wants to merge 2 commits into
Conversation
|
One concern I'd like to raise for review: this change may break user-specific color configurations. Users can configure I have already seen users who were unhappy with the default colors and had configured their own. Are we allowed to break their configuration with this change? Should we add a migration note, or is there a way to preserve the user experience for those who have already customized their colors? Happy to hear the community's view on this before merging. |
Test Results 51 files ± 0 51 suites ±0 35m 4s ⏱️ - 22m 17s For more details on these failures, see this check. Results for commit 9c46524. ± Comparison against base commit 8b229d0. This pull request removes 125 and adds 483 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jasmin261098
left a comment
There was a problem hiding this comment.
As far as I can check this looks good to me.
A note for users who have adjusted their colors to the current scale would be good. It might confuse some people, but solving the underlying problem makes sense.
f7ea397 to
7073a92
Compare
Fixes #2993.
Diff highlights are hard to distinguish from the editor background in the dark theme. This change uses stronger dark-theme blends shared by two-way Compare and Unified Diff, and aligns the annotation colors with those blends. The light-theme palette and configurable base colors are preserved.
This remains a draft pending expert review of theme detection and the changed appearance of colors that users have customized for the old dark-theme blends.
Developed with the help of Claude Code (Anthropic) and Codex.