Repository navigation
🐛 FIX: Keep project: references inside the project - #1239
Open
Cherith1222 wants to merge 1 commit into
Open
Cherith1222 wants to merge 1 commit into
Cherith1222 wants to merge 1 commit into
Conversation
A missing project: target was resolved through an intersphinx inventory.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1235.
project:is an internal reference, andinv:is the intersphinx scheme. Theproject:prefix was removed and the target was then resolved like a plain#link, so a name missing from this project could match an external inventory.A plain
#link still falls through to an inventory.Tests, on Windows with Python 3.13.3:
test_project_scheme_does_not_use_intersphinxfailed.<project:#paragraph-target>and[explicit](project:#paragraph-target)both linked tohttps://example.com/index.html#paragraph-target, and the build raised nomyst.xref_missingwarning.tests/test_renderers/test_fixtures_sphinx.py::test_link_resolution,tests/test_renderers/test_fixtures_docutils.py::test_link_resolution, andtests/test_sphinx/test_sphinx_builds.py::test_referencesalso passed (18 passed together with the new test).ruff0.17.4checkandruff format --checkpassed on the five Python files in this change.Not run: the full suite, tox, mypy, and pre-commit.
This patch was drafted with AI assistance (Grok 4.7 in Cursor).