Repository navigation
🐛 FIX: Allow an HTML comment whose text ends with a hyphen - #478
Open
Shriraj1901 wants to merge 1 commit into
Open
Shriraj1901 wants to merge 1 commit into
Shriraj1901 wants to merge 1 commit into
Conversation
CommonMark 0.31 only forbids `-->` inside the text of an HTML comment, so
`<!-- note --->` and `<!----->` are valid raw HTML (cmark, commonmark.js and
markdown-it 15 all pass them through). The inline HTML regex still used the
older grammar, which cannot match a text that ends in `-`, so these comments
were rendered as escaped text:
MarkdownIt("commonmark").renderInline("<!-- note --->")
# '<!-- note --->'
Match the text lazily up to the first `-->` instead. Unterminated comments are
still rejected before the regex runs, so the scan cannot go past a terminator
that exists.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonMark 0.31 only forbids
-->inside the text of an HTML comment, so<!-- note --->and<!----->are valid raw HTML (cmark, commonmark.js and markdown-it 15 all pass them through). The inline HTML regex still used the older grammar, which cannot match a text that ends in-, so these comments were rendered as escaped text:Match the text lazily up to the first
-->instead. Unterminated comments are still rejected before the regex runs, so the scan cannot go past a terminator that exists.