Repository navigation
test: cover ignoreTrailingSlash for websocket upgrades, update README - #498
Merged
Merged
Conversation
ilteoood
reviewed
Nov 18, 2026
ilteoood
reviewed
Nov 18, 2026
ilteoood
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
ignoreTrailingSlashand remove the outdated entries from the README.ignoreTrailingSlash" among the missing WebSocket features, but upgrades are dispatched through the regular Fastify router and the same handler as HTTP requests, so the option already applies to them. There was no WebSocket test covering it, though.Changes:
test/ws-ignore-trailing-slash.js, which checks that withignoreTrailingSlash: trueupgrades are proxied to the expected upstream path for prefixes with and without a trailing slash, withrewritePrefix, and next to anotherupgradelistener. It also checks the opposite case:/api/prefix refuses/apiwith a 404.ignoreTrailingSlashfrom the list of missing WebSocket features in the README. Request id logging and forwarding of multiple subprotocols are still listed.TODOsection from the README. Its two entries date back to 2018 and 2020: the WebSocket one is covered in more detail by thewebsocketsection, and incoming data can be validated through thepreValidationoption.Note: