Skip to content

Compute the sampling standard deviation once per SE ratio - #36

Merged
soodoku merged 1 commit into
mainfrom
perf/reuse-sampling-sd
Nov 21, 2026
Merged

soodoku merged 1 commit into
mainfrom
perf/reuse-sampling-sd

Conversation

@soodoku

@soodoku soodoku commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

The standard-error ratio computes the sampling standard deviation to check for zero, then immediately recomputes it for division. Keep that number in a local variable for the duration of the property call.

Using 200,000 replicate values, the public ratio took 0.314 → 0.169 ms. The public summary took 0.564 → 0.429 ms. Medians use five alternating pairs, each timing 20 calls. The ratio agrees with Python statistics.stdev to 1e-14. All 95 tests passed locally.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T21:53:40.648414Z a86921b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soodoku
soodoku merged commit bf4cd87 into main Nov 21, 2026
12 checks passed
@soodoku
soodoku deleted the perf/reuse-sampling-sd branch November 21, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant